Skip to content

Conversation

@Tr01ler
Copy link
Contributor

@Tr01ler Tr01ler commented Jan 14, 2026

No description provided.

@Tr01ler Tr01ler linked an issue Jan 14, 2026 that may be closed by this pull request
Copy link

@yingchan-dev yingchan-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In lib/dev/FakeData.ts, the URLs for names were changed from .json files to general web pages. However, if our code uses something like say, fetch().json() to parse these, it will likely crash because it will receive HTML instead of a JSON array. Also, I noticed in .env.test, if we point the http://localhost:3000 to /api/, we might run into issues where the library appends another /api/auth to it, resulting in a 404 at .../api/api/auth. However, everything else looks great! 😁

Copy link

@yingchan-dev yingchan-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In lib/dev/FakeData.ts, the URLs for names were changed from .json files to general web pages. However, if our code uses something like say, fetch().json() to parse these, it will likely crash because it will receive HTML instead of a JSON array. Also, I noticed in .env.test, if we point the http://localhost:3000 to /api/, we might run into issues where the library appends another /api/auth to it, resulting in a 404 at .../api/api/auth. However, everything else looks great! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FTC Decode

5 participants