-
Notifications
You must be signed in to change notification settings - Fork 3
FTC Decode #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
FTC Decode #528
Conversation
…ere using before changed
yingchan-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In lib/dev/FakeData.ts, the URLs for names were changed from .json files to general web pages. However, if our code uses something like say, fetch().json() to parse these, it will likely crash because it will receive HTML instead of a JSON array. Also, I noticed in .env.test, if we point the http://localhost:3000 to /api/, we might run into issues where the library appends another /api/auth to it, resulting in a 404 at .../api/api/auth. However, everything else looks great! 😁
yingchan-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In lib/dev/FakeData.ts, the URLs for names were changed from .json files to general web pages. However, if our code uses something like say, fetch().json() to parse these, it will likely crash because it will receive HTML instead of a JSON array. Also, I noticed in .env.test, if we point the http://localhost:3000 to /api/, we might run into issues where the library appends another /api/auth to it, resulting in a 404 at .../api/api/auth. However, everything else looks great! 😁
No description provided.